-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid derivation of fixed fractionDigits #34973
Conversation
Tagging subscribers to this area: @buyaa-n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrj001 Thank you for noticing this and fixing, left one NIT comment, other than that looks good to me
@buyaa-n Note that I also had to removed "fixed='true'" from another test (FractionDigitsMismatch_Throws). It wasn't needed for this test, but at the time the test was created, it was not honored. Therefore, I hadn't noticed the error. With the fix to this issue, that test started failing due to a different exception being thrown now that the fixed facet was honored. |
Thank you @mrj001, the tests might fail on full framework too, might need to add SkipOnTargetFramework |
…o alter the fixed value of fractionDigits from the base type.
… FractionDigitsMismatch_Throws was created.
…, this test would fail on i.
…Throws test as the wrong exception is being thrown by .NET Framework 4.7.2. -removed extra blank line at end of file.
@buyaa-n .NET Framework 4.7.2 is also throwing the "totalDigits" error message in the |
Great, looks good, thank you @mrj001. The CI legs showing still in progress were successfully finished in details on Azure Pipelines, gonna merge this PR |
@buyaa-n
fix #34418